Skip to content

fix(image): image loading when the path contains a space #21605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(image): image loading when the path contains a space #21605

wants to merge 3 commits into from

Conversation

@ramezgerges
Copy link
Contributor

@ramezgerges ramezgerges commented Oct 14, 2025

GitHub Issue: https://github.com/unoplatform/kahua-private/issues/304

PR Type:

What is the current behavior? 🤔

What is the new behavior? 🚀

PR Checklist ✅

Please check if your PR fulfills the following requirements:

Other information ℹ️

@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/automation Categorizes an issue or PR as relevant to project automation labels Oct 14, 2025
@unodevops
Copy link
Contributor

unodevops commented Oct 14, 2025

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21605/docs/index.html

@unodevops
Copy link
Contributor

unodevops commented Oct 14, 2025

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21605/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

unodevops commented Oct 14, 2025

⚠️⚠️ The build 178492 has failed on Uno.UI - CI.

ajpinedam
ajpinedam approved these changes Oct 15, 2025
View reviewed changes
src/Uno.UWP/Helpers/PlatformImageHelpers.skia.cs
{
var path = uri.PathAndQuery;
// Unescaping is necessary for things like spaces that are valid in a file system path but not in a URI
var path = Uri.UnescapeDataString(uri.AbsolutePath);
Copy link
Contributor

@ajpinedam ajpinedam Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, no need for the query here? (PathAndQuery vs AbsolutePath)

Copy link
Contributor Author

@ramezgerges ramezgerges Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is specifically for local paths, so the query should always be empty.

@ramezgerges ramezgerges enabled auto-merge October 27, 2025 16:05
@unodevops
Copy link
Contributor

unodevops commented Oct 27, 2025

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21605/docs/index.html

@unodevops
Copy link
Contributor

unodevops commented Oct 27, 2025

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21605/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

unodevops commented Oct 27, 2025

⚠️⚠️ The build 179840 has failed on Uno.UI - CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajpinedam ajpinedam ajpinedam approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ramezgerges @unodevops @ajpinedam